kotatogram/cmake_helpers
1
0
Fork 0
Code Issues Activity

Do not enforce NDEBUG macro

Browse source 
It affects WebRTC classes which may vary their size that eventually
leads to memory corruption and crashes. CMake already defines the macro
for production build types. One can use a custom build type which does
not imply NDEBUG. Please note, tg_owt and tdesktop must be build with
the same CMAKE_BUILD_TYPE.
This commit is contained in:
Nicholas Guriev 2021-03-04 18:58:03 +03:00 • committed by John Preston
parent 2f4cbdd126
commit 25f0733a60
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
options.cmake
View file

@ -9,7 +9,7 @@ add_library(desktop-app::common_options ALIAS common_options)
target_compile_definitions(common_options
INTERFACE
$<IF:$<CONFIG:Debug>,_DEBUG,NDEBUG>
$<$<CONFIG:Debug>:_DEBUG>
QT_NO_KEYWORDS
QT_NO_CAST_FROM_BYTEARRAY
)