[Improvement] Jump to date and time

This commit is contained in:
Eric Kotato 2022-09-11 03:07:21 +03:00 committed by Eric Kotato
parent 9895127b60
commit 9854a7a5d5
15 changed files with 190 additions and 57 deletions

Binary file not shown.

After

Width:  |  Height:  |  Size: 195 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 313 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 418 B

View file

@ -188,6 +188,10 @@
"ktg_settings_compress_images_default": "Compress images by default",
"ktg_pip_not_supported": "Sorry, Picture-in-Picture mode is not supported here.",
"ktg_forward_quiz_unquoted": "Sorry, quizzes that are currently open and unvoted on cannot be forwarded unquoted.",
"ktg_jump_to_date_title": "Jump to...",
"ktg_jump_to_date_button": "Jump",
"ktg_jump_to_beginning": "Jump to beginning",
"ktg_show_calendar": "Show calendar",
"ktg_in_app_update_disabled": "In-app updater is disabled.",
"ktg_settings_view_profile_on_top": "Show \"View Profile\" first",
"ktg_settings_view_profile_on_top_about": "This option also enables \"Add \"View Profile\"\" from TDesktop's experimental settings.",

View file

@ -2925,7 +2925,7 @@ void ApiWrap::readFeaturedSets() {
void ApiWrap::resolveJumpToDate(
Dialogs::Key chat,
const QDate &date,
const QDateTime &date,
Fn<void(not_null<PeerData*>, MsgId)> callback) {
if (const auto peer = chat.peer()) {
const auto topic = chat.topic();
@ -2938,13 +2938,13 @@ template <typename Callback>
void ApiWrap::requestMessageAfterDate(
not_null<PeerData*> peer,
MsgId topicRootId,
const QDate &date,
const QDateTime &date,
Callback &&callback) {
// API returns a message with date <= offset_date.
// So we request a message with offset_date = desired_date - 1 and add_offset = -1.
// This should give us the first message with date >= desired_date.
const auto offsetId = 0;
const auto offsetDate = static_cast<int>(date.startOfDay().toSecsSinceEpoch()) - 1;
const auto offsetDate = static_cast<int>(date.toSecsSinceEpoch()) - 1;
const auto addOffset = -1;
const auto limit = 1;
const auto maxId = 0;
@ -3021,7 +3021,7 @@ void ApiWrap::requestMessageAfterDate(
void ApiWrap::resolveJumpToHistoryDate(
not_null<PeerData*> peer,
MsgId topicRootId,
const QDate &date,
const QDateTime &date,
Fn<void(not_null<PeerData*>, MsgId)> callback) {
if (const auto channel = peer->migrateTo()) {
return resolveJumpToHistoryDate(

View file

@ -265,7 +265,7 @@ public:
void resolveJumpToDate(
Dialogs::Key chat,
const QDate &date,
const QDateTime &date,
Fn<void(not_null<PeerData*>, MsgId)> callback);
using SliceType = Data::LoadDirection;
@ -481,13 +481,13 @@ private:
void resolveJumpToHistoryDate(
not_null<PeerData*> peer,
MsgId topicRootId,
const QDate &date,
const QDateTime &date,
Fn<void(not_null<PeerData*>, MsgId)> callback);
template <typename Callback>
void requestMessageAfterDate(
not_null<PeerData*> peer,
MsgId topicRootId,
const QDate &date,
const QDateTime &date,
Callback &&callback);
void sharedMediaDone(

View file

@ -2733,7 +2733,7 @@ void Widget::clearSearchCache() {
void Widget::showCalendar() {
if (_searchInChat) {
controller()->showCalendar(_searchInChat, QDate());
controller()->showCalendar(_searchInChat, QDateTime());
}
}

View file

@ -3668,9 +3668,9 @@ void HistoryInner::mouseActionUpdate() {
if (point.x() >= dateLeft && point.x() < dateLeft + dateWidth) {
if (!_scrollDateLink) {
_scrollDateLink = std::make_shared<Window::DateClickHandler>(item->history(), view->dateTime().date());
_scrollDateLink = std::make_shared<Window::DateClickHandler>(item->history(), view->dateTime());
} else {
static_cast<Window::DateClickHandler*>(_scrollDateLink.get())->setDate(view->dateTime().date());
static_cast<Window::DateClickHandler*>(_scrollDateLink.get())->setDate(view->dateTime());
}
dragState = TextState(
nullptr,

View file

@ -990,7 +990,7 @@ ComposeSearch::Inner::Inner(
_bottomBar->showCalendarRequests(
) | rpl::start_with_next([=] {
hideList();
_window->showCalendar({ _history }, QDate());
_window->showCalendar({ _history }, QDateTime());
}, _bottomBar->lifetime());
_bottomBar->showBoxFromRequests(

View file

@ -2556,7 +2556,7 @@ void RepliesWidget::listUpdateDateLink(
link = nullptr;
return;
}
const auto date = view->dateTime().date();
const auto date = view->dateTime();
if (!link) {
link = std::make_shared<Window::DateClickHandler>(_topic, date);
} else {

View file

@ -48,6 +48,7 @@ public:
void skipMonth(int skip);
void showMonth(QDate month);
void skipDays(int skip);
[[nodiscard]] bool showsMonthOf(QDate date) const;
[[nodiscard]] int highlightedIndex() const {
@ -68,6 +69,9 @@ public:
[[nodiscard]] bool isEnabled(int index) const {
return (index >= _minDayIndex) && (index <= _maxDayIndex);
}
QDate highlighted() const {
return _highlighted;
}
[[nodiscard]] QDate month() const {
return _month.current();
@ -99,6 +103,7 @@ private:
static int DaysShiftForMonth(QDate month, QDate min);
static int RowsCountForMonth(QDate month, QDate min, QDate max);
void setHighlightedDate(QDate highlighted);
bool _allowsSelection = false;
@ -197,6 +202,36 @@ void CalendarBox::Context::skipMonth(int skip) {
showMonth(QDate(year, month, 1));
}
void CalendarBox::Context::skipDays(int skip) {
auto date = _highlighted;
if (_month.current().month() == _highlighted.month()
&& _month.current().year() == _highlighted.year()) {
date = date.addDays(skip);
} else if (skip < 0) {
date = QDate(
_month.current().year(),
_month.current().month(),
_month.current().daysInMonth());
} else {
date = QDate(
_month.current().year(),
_month.current().month(),
1);
}
if (date.isValid() && date >= _min && date <= _max) {
auto needMonthChange = (date.month() != _highlighted.month()
|| date.year() != _highlighted.year());
setHighlightedDate(date);
if (needMonthChange) {
showMonth(date);
}
}
}
int CalendarBox::Context::DaysShiftForMonth(QDate month, QDate min) {
Expects(!month.isNull());
@ -245,6 +280,12 @@ int CalendarBox::Context::RowsCountForMonth(
return cellsFull / kDaysInWeek;
}
void CalendarBox::Context::setHighlightedDate(QDate highlighted) {
_highlighted = highlighted;
_highlightedIndex = _month.current().daysTo(_highlighted);
applyMonth(_month.current(), true);
}
QDate CalendarBox::Context::dateFromIndex(int index) const {
constexpr auto kMonthsCount = 12;
auto month = _month.current().month();
@ -350,6 +391,9 @@ public:
[[nodiscard]] int countMaxHeight() const;
void setDateChosenCallback(Fn<void(QDate)> callback);
void selectBeginning();
void selectEnd();
void selectHighlighted();
~Inner();
@ -728,6 +772,18 @@ void CalendarBox::Inner::setDateChosenCallback(Fn<void(QDate)> callback) {
_dateChosenCallback = std::move(callback);
}
void CalendarBox::Inner::selectBeginning() {
_dateChosenCallback(_context->dateFromIndex(_context->minDayIndex()));
}
void CalendarBox::Inner::selectEnd() {
_dateChosenCallback(_context->dateFromIndex(_context->maxDayIndex()));
}
void CalendarBox::Inner::selectHighlighted() {
_dateChosenCallback(_context->highlighted());
}
CalendarBox::Inner::~Inner() = default;
class CalendarBox::Title final : public RpWidget {
@ -1135,14 +1191,20 @@ void CalendarBox::keyPressEvent(QKeyEvent *e) {
jump(_previous.data());
} else if (e->key() == Qt::Key_End) {
jump(_next.data());
} else if (e->key() == Qt::Key_Left
|| e->key() == Qt::Key_Up
|| e->key() == Qt::Key_PageUp) {
} else if (e->key() == Qt::Key_PageUp) {
goPreviousMonth();
} else if (e->key() == Qt::Key_Right
|| e->key() == Qt::Key_Down
|| e->key() == Qt::Key_PageDown) {
} else if (e->key() == Qt::Key_PageDown) {
goNextMonth();
} else if (e->key() == Qt::Key_Left) {
_context->skipDays(-1);
} else if (e->key() == Qt::Key_Right) {
_context->skipDays(1);
} else if (e->key() == Qt::Key_Up) {
_context->skipDays(-7);
} else if (e->key() == Qt::Key_Down) {
_context->skipDays(7);
} else if (e->key() == Qt::Key_Return || e->key() == Qt::Key_Enter) {
_inner->selectHighlighted();
}
}

View file

@ -26,12 +26,7 @@ namespace {
constexpr auto kMinimalSchedule = TimeId(10);
QString DayString(const QDate &date) {
return tr::lng_month_day(
tr::now,
lt_month,
Lang::MonthDay(date.month())(tr::now),
lt_day,
QString::number(date.day()));
return langDayOfMonthFull(date);
}
QString TimeString(QTime time) {

View file

@ -80,6 +80,7 @@ menuIconPorn: icon {{ "menu/porn", menuIconColor }};
menuIconViolence: icon {{ "menu/violence", menuIconColor }};
menuIconHide: icon {{ "menu/hide", menuIconColor }};
menuIconMention: icon {{ "menu/mention", menuSubmenuArrowFg }};
menuIconToBeginning: icon {{ "menu/to_beginning", menuSubmenuArrowFg }};
menuIconMuteFor: icon {{ "menu/mute_for", menuIconColor }};
menuIconSilent: icon {{ "menu/silent", menuIconColor }};
menuIconCustomize: icon {{ "menu/customize", menuIconColor }};

View file

@ -7,6 +7,8 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
*/
#include "window/window_session_controller.h"
#include "kotato/kotato_settings.h"
#include "kotato/kotato_lang.h"
#include "boxes/add_contact_box.h"
#include "boxes/peers/add_bot_to_chat_box.h"
#include "boxes/peers/edit_peer_info_box.h"
@ -59,8 +61,10 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
#include "ui/toast/toast.h"
#include "calls/calls_instance.h" // Core::App().calls().inCall().
#include "calls/group/calls_group_call.h"
#include "ui/boxes/choose_date_time.h"
#include "ui/boxes/calendar_box.h"
#include "ui/boxes/confirm_box.h"
#include "ui/widgets/popup_menu.h"
#include "mainwidget.h"
#include "main/main_account.h"
#include "main/main_domain.h"
@ -83,6 +87,8 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
#include "styles/style_window.h"
#include "styles/style_dialogs.h"
#include "styles/style_layers.h" // st::boxLabel
#include "styles/style_info.h"
#include "styles/style_menu_icons.h"
namespace Window {
namespace {
@ -244,6 +250,53 @@ void MainWindowShow::processChosenSticker(
}
}
void ChooseJumpDateTimeBox(
not_null<Ui::GenericBox*> box,
QDateTime minDate,
QDateTime maxDate,
QDateTime highlighted,
Fn<void(TimeId)> onDone,
Fn<void()> onBegnning,
Fn<void()> onCalendar,
bool hasCalendar) {
auto descriptor = Ui::ChooseDateTimeBox(box,
Ui::ChooseDateTimeBoxArgs{
.title = rktr("ktg_jump_to_date_title"),
.submit = rktr("ktg_jump_to_date_button"),
.done = std::move(onDone),
.min = [=] { return base::unixtime::serialize(minDate); },
.time = base::unixtime::serialize(highlighted),
.max = [=] { return base::unixtime::serialize(maxDate); },
});
const auto topMenuButton = box->addTopButton(st::infoTopBarMenu);
const auto menu = std::make_shared<base::unique_qptr<Ui::PopupMenu>>();
topMenuButton.data()->setClickedCallback([=] {
*menu = base::make_unique_q<Ui::PopupMenu>(
topMenuButton.data(),
st::popupMenuWithIcons);
(*menu)->addAction(
ktr("ktg_jump_to_beginning"),
std::move(onBegnning),
&st::menuIconToBeginning);
if (hasCalendar) {
(*menu)->addAction(
ktr("ktg_show_calendar"),
std::move(onCalendar),
&st::menuIconSchedule);
}
(*menu)->setForcedOrigin(Ui::PanelAnimation::Origin::TopRight);
const auto buttonTopLeft = topMenuButton.data()->mapToGlobal(QPoint());
const auto buttonRect = QRect(buttonTopLeft, topMenuButton.data()->size());
const auto pos = QPoint(
buttonRect.x() + buttonRect.width(),
buttonRect.y() + buttonRect.height());
(*menu)->popup(pos);
return true;
});
}
} // namespace
void ActivateWindow(not_null<SessionController*> controller) {
@ -270,13 +323,13 @@ bool operator!=(const PeerThemeOverride &a, const PeerThemeOverride &b) {
return !(a == b);
}
DateClickHandler::DateClickHandler(Dialogs::Key chat, QDate date)
DateClickHandler::DateClickHandler(Dialogs::Key chat, QDateTime date)
: _chat(chat)
, _weak(chat.topic())
, _date(date) {
}
void DateClickHandler::setDate(QDate date) {
void DateClickHandler::setDate(QDateTime date) {
_date = date;
}
@ -1957,7 +2010,7 @@ void SessionController::startOrJoinGroupCall(
Core::App().calls().startOrJoinGroupCall(uiShow(), peer, args);
}
void SessionController::showCalendar(Dialogs::Key chat, QDate requestedDate) {
void SessionController::showCalendar(Dialogs::Key chat, QDateTime requestedDate) {
const auto topic = chat.topic();
const auto history = chat.owningHistory();
if (!history) {
@ -1966,11 +2019,11 @@ void SessionController::showCalendar(Dialogs::Key chat, QDate requestedDate) {
const auto currentPeerDate = [&] {
if (topic) {
if (const auto item = topic->lastMessage()) {
return base::unixtime::parse(item->date()).date();
return base::unixtime::parse(item->date());
}
return QDate();
return QDateTime();
} else if (history->scrollTopItem) {
return history->scrollTopItem->dateTime().date();
return history->scrollTopItem->dateTime();
} else if (history->loadedAtTop()
&& !history->isEmpty()
&& history->peer->migrateFrom()) {
@ -1978,41 +2031,41 @@ void SessionController::showCalendar(Dialogs::Key chat, QDate requestedDate) {
if (migrated->scrollTopItem) {
// We're up in the migrated history.
// So current date is the date of first message here.
return history->blocks.front()->messages.front()->dateTime().date();
return history->blocks.front()->messages.front()->dateTime();
}
}
} else if (const auto item = history->lastMessage()) {
return base::unixtime::parse(item->date()).date();
return base::unixtime::parse(item->date());
}
return QDate();
return QDateTime();
}();
const auto maxPeerDate = [&] {
if (topic) {
if (const auto item = topic->lastMessage()) {
return base::unixtime::parse(item->date()).date();
return base::unixtime::parse(item->date());
}
return QDate();
return QDateTime();
}
const auto check = history->peer->migrateTo()
? history->owner().historyLoaded(history->peer->migrateTo())
: history;
if (const auto item = check ? check->lastMessage() : nullptr) {
return base::unixtime::parse(item->date()).date();
return base::unixtime::parse(item->date());
}
return QDate();
return QDateTime();
}();
const auto minPeerDate = [&] {
const auto startDate = [&] {
// Telegram was launched in August 2013 :)
return QDate(2013, 8, 1);
return QDate(2013, 8, 1).startOfDay();
};
if (topic) {
return base::unixtime::parse(topic->creationDate()).date();
return base::unixtime::parse(topic->creationDate());
} else if (const auto chat = history->peer->migrateFrom()) {
if (const auto history = chat->owner().historyLoaded(chat)) {
if (history->loadedAtTop()) {
if (!history->isEmpty()) {
return history->blocks.front()->messages.front()->dateTime().date();
return history->blocks.front()->messages.front()->dateTime();
}
} else {
return startDate();
@ -2021,9 +2074,9 @@ void SessionController::showCalendar(Dialogs::Key chat, QDate requestedDate) {
}
if (history->loadedAtTop()) {
if (!history->isEmpty()) {
return history->blocks.front()->messages.front()->dateTime().date();
return history->blocks.front()->messages.front()->dateTime();
}
return QDate::currentDate();
return QDateTime::currentDateTime();
}
return startDate();
}();
@ -2031,7 +2084,8 @@ void SessionController::showCalendar(Dialogs::Key chat, QDate requestedDate) {
? requestedDate
: !currentPeerDate.isNull()
? currentPeerDate
: QDate::currentDate();
: QDateTime::currentDateTime();
struct ButtonState {
enum class Type {
None,
@ -2090,9 +2144,10 @@ void SessionController::showCalendar(Dialogs::Key chat, QDate requestedDate) {
button->setPointerCursor(false);
}
};
const auto weak = base::make_weak(this);
const auto weakTopic = base::make_weak(topic);
const auto jump = [=](const QDate &date) {
const auto jump = [=](const QDateTime &date) {
const auto open = [=](not_null<PeerData*> peer, MsgId id) {
if (const auto strong = weak.get()) {
if (!topic) {
@ -2113,15 +2168,31 @@ void SessionController::showCalendar(Dialogs::Key chat, QDate requestedDate) {
session().api().resolveJumpToDate(chat, date, open);
}
};
show(Box<Ui::CalendarBox>(Ui::CalendarBoxArgs{
.month = highlighted,
.highlighted = highlighted,
.callback = [=](const QDate &date) { jump(date); },
.minDate = minPeerDate,
.maxDate = maxPeerDate,
.allowsSelection = history->peer->isUser(),
.selectionChanged = selectionChanged,
}));
const auto showCalendarCallback = [=] {
show(Box<Ui::CalendarBox>(Ui::CalendarBoxArgs{
.month = highlighted.date(),
.highlighted = highlighted.date(),
.callback = [=](const QDate &date) { jump(date.startOfDay()); },
.minDate = minPeerDate.date(),
.maxDate = maxPeerDate.date(),
.allowsSelection = history->peer->isUser(),
.selectionChanged = selectionChanged,
}), Ui::LayerOption::CloseOther);
};
show(Box(ChooseJumpDateTimeBox,
minPeerDate,
maxPeerDate,
highlighted,
[=](TimeId result) {
jump(base::unixtime::parse(result));
},
[=] {
jump(minPeerDate);
},
std::move(showCalendarCallback),
history->peer->isUser()),
Ui::LayerOption::KeepOther);
}
void SessionController::showPassportForm(const Passport::FormRequest &request) {

View file

@ -100,15 +100,15 @@ bool operator!=(const PeerThemeOverride &a, const PeerThemeOverride &b);
class DateClickHandler : public ClickHandler {
public:
DateClickHandler(Dialogs::Key chat, QDate date);
DateClickHandler(Dialogs::Key chat, QDateTime date);
void setDate(QDate date);
void setDate(QDateTime date);
void onClick(ClickContext context) const override;
private:
Dialogs::Key _chat;
base::weak_ptr<Data::ForumTopic> _weak;
QDate _date;
QDateTime _date;
};
@ -458,7 +458,7 @@ public:
void showCalendar(
Dialogs::Key chat,
QDate requestedDate);
QDateTime requestedDateTime);
void showAddContact();
void showNewGroup();