From 9ebfd80b2980600f0c7230575896537b6e5485a2 Mon Sep 17 00:00:00 2001 From: John Preston Date: Mon, 20 Jun 2022 23:44:44 +0400 Subject: [PATCH] Fix possible stack overflow crash. --- ui/widgets/scroll_area.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/widgets/scroll_area.cpp b/ui/widgets/scroll_area.cpp index b7bd1d2..706bc14 100644 --- a/ui/widgets/scroll_area.cpp +++ b/ui/widgets/scroll_area.cpp @@ -254,6 +254,7 @@ void ScrollBar::mousePressEvent(QMouseEvent *e) { if (!width() || !height()) return; _dragStart = e->globalPos(); + area()->setMovingByScrollBar(true); setMoving(true); if (_overbar) { _startFrom = _connected->value(); @@ -265,15 +266,12 @@ void ScrollBar::mousePressEvent(QMouseEvent *e) { _connected->setValue(_startFrom); setOverBar(true); } - - area()->setMovingByScrollBar(true); } void ScrollBar::mouseReleaseEvent(QMouseEvent *e) { if (_moving) { - setMoving(false); - area()->setMovingByScrollBar(false); + setMoving(false); } if (!_over) { setMouseTracking(false);