kotatogram/lib_ui
1
0
Fork 0
Code Issues Activity

Revert "Use glib to open URLs on Linux"

Browse source 
This reverts commit a7117df837.
This commit is contained in:
Ilya Fedin 2023-09-03 14:31:35 +04:00 • committed by John Preston
parent d3ac9dcf97
commit a22254860f
1 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
ui/basic_click_handlers.cpp
View file

@ -11,17 +11,12 @@
#include "ui/integration.h" #include "ui/integration.h"
#include "base/qthelp_url.h" #include "base/qthelp_url.h"
#include "base/qt/qt_string_view.h" #include "base/qt/qt_string_view.h"
#include "base/platform/linux/base_linux_app_launch_context.h"
#include <QtCore/QUrl> #include <QtCore/QUrl>
#include <QtCore/QRegularExpression> #include <QtCore/QRegularExpression>
#include <QtGui/QDesktopServices> #include <QtGui/QDesktopServices>
#include <QtGui/QGuiApplication> #include <QtGui/QGuiApplication>
#if __has_include(<gio/gio.hpp>)
#include <gio/gio.hpp>
#endif // __has_include(<gio/gio.hpp>)
QString TextClickHandler::readable() const { QString TextClickHandler::readable() const {
const auto result = url(); const auto result = url();
return !result.startsWith(qstr("internal:")) return !result.startsWith(qstr("internal:"))
@ -85,26 +80,6 @@ void UrlClickHandler::Open(QString url, QVariant context) {
if (IsEmail(url)) { if (IsEmail(url)) {
url = "mailto: " + url; url = "mailto: " + url;
} }
#if __has_include(<gio/gio.hpp>)
// Desktop entry spec implementation,
// prefer it over QDesktopServices::openUrl since it just calls
// the xdg-open shell script that is known to be bugged:
// various shell-specific bugs with spaces in paths,
// logic bugs violating the spec and etc, etc.
// Not to mention xdg-open can and will use DE-specific executables
// that allows various ill people to develop extensions
// to the standard and differ the behavior across apps.
// https://specifications.freedesktop.org/desktop-entry-spec/latest/
{
using namespace gi::repository;
if (Gio::AppInfo::launch_default_for_uri(
url.toStdString(),
base::Platform::AppLaunchContext(),
nullptr)) {
return;
}
}
#endif // __has_include(<gio/gio.hpp>)
QDesktopServices::openUrl(url); QDesktopServices::openUrl(url);
} }
} }